Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<footer> Element #17

Open
joshsweaney opened this issue May 18, 2020 · 9 comments
Open

<footer> Element #17

joshsweaney opened this issue May 18, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@joshsweaney
Copy link

joshsweaney commented May 18, 2020

To complement the <header> you can create, why not add some basic styling for a <footer> that must be at the bottom of the body, which makes a slightly darker footer that sticks to the bottom of the window? A sticky footer is one of those boilerplate bits of code that would be nice to have if a header is already there. It should have identical styling to the header.

@ZeroThe2nd
Copy link

Having it stick to the bottom of the screen or bottom of the full page?

Bottom of the page would make sense, whereas bottom of the screen would not. One can always opt to add a display:sticky; bottom:0; by themselves if someone would really want it to be sticky. Just adding the styling itself so one can add a footer should be sufficient.

@joshsweaney
Copy link
Author

joshsweaney commented May 19, 2020 via email

@3x
Copy link
Member

3x commented May 19, 2020

Good idea! Will be added later today.

@okeken
Copy link

okeken commented May 20, 2020

@3x has it been added?

@3x
Copy link
Member

3x commented May 22, 2020

@3x has it been added?

Ended up getting pushed back. This will be added in 1.3.0.

@3x 3x added the enhancement New feature or request label May 22, 2020
@pimhakkert
Copy link

Any update on this? @3x

@ZeroThe2nd
Copy link

@pimhakkert You can always make a PR yourself if you need the feature this much 😉

@pimhakkert
Copy link

@ZeroThe2nd That's true, but @3x already said it's scheduled for a later version. I don't want to get in the middle of that. I wouldn't consider myself good enough to do it anyways.

@ZeroThe2nd
Copy link

@pimhakkert Why not give it a try anyway? Give it a fork and try to implement it how you think is right, and make a PR. @3x can at the very least use it as a basis at the very least. Who knows, maybe you're better than you think. Don't undersell yourself 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants