From bd29b8f28806d7389472fa64c235496fcc4ff80c Mon Sep 17 00:00:00 2001 From: davemarco <83603688+davemarco@users.noreply.github.com> Date: Thu, 10 Oct 2024 15:05:18 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com> --- src/clp_ffi_js/ir/StreamReader.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/clp_ffi_js/ir/StreamReader.cpp b/src/clp_ffi_js/ir/StreamReader.cpp index 748f0bf9..096f6f59 100644 --- a/src/clp_ffi_js/ir/StreamReader.cpp +++ b/src/clp_ffi_js/ir/StreamReader.cpp @@ -114,10 +114,14 @@ void StreamReader::filter_log_events(emscripten::val const& log_level_filter) { } m_filtered_log_event_map.emplace(); - auto filter_levels{emscripten::vecFromJSArray(log_level_filter)}; + auto filter_levels{emscripten::vecFromJSArray>(log_level_filter + )}; for (size_t log_event_idx = 0; log_event_idx < m_encoded_log_events.size(); ++log_event_idx) { auto const& log_event = m_encoded_log_events[log_event_idx]; - if (std::ranges::find(filter_levels, static_cast(log_event.get_log_level())) + if (std::ranges::find( + filter_levels, + clp::enum_to_underlying_type(log_event.get_log_level()) + ) != filter_levels.end()) { m_filtered_log_event_map->emplace_back(log_event_idx);