Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string_utils requires an awkward include path in dependent projects #571

Open
kirkrodrigues opened this issue Nov 4, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@kirkrodrigues
Copy link
Member

Bug

In dependent projects like clp-ffi-js, the string_utils library requires that we set the include path to components/core/src/clp/, but other clp-core headers require the include path to be set to components/core/src/. This leads to error-prone include statements since the former allows all top-level clp-core headers to be included directly without the clp/ prefix (e.g, <Array.hpp>).

CLP version

9f6a6ce

Environment

N/A

Reproduction steps

See https://github.com/y-scope/clp-ffi-js/blob/82079a5382230da5fe1b1cfbc0c1a4f66f34b98f/src/clp_ffi_js/ir/StreamReader.hpp#L4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant