Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: Support retrieving node ID from a clp::ffi::SchemaTree::NodeLocator. #572

Open
junhaoliao opened this issue Nov 6, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@junhaoliao
Copy link
Collaborator

Request

If we can retrieve node ID from a clp::ffi::SchemaTree::NodeLocator, in subscriptions to schema tree node insertions (i.e. IrUnitHandler::handle_schema_tree_node_insertion) we will be able to compare the node's key name and store ID of the tree nodes in interest to improve log viewing experience.
"tree nodes in interest" - examples include log level & timestamp kv-pairs.

Possible implementation

Add a public method into the class like get_node_id().

@junhaoliao junhaoliao added the enhancement New feature or request label Nov 6, 2024
@junhaoliao
Copy link
Collaborator Author

junhaoliao commented Nov 6, 2024

For now, clp-ffi-js can mitigate by maintaining a counter in the IrUnitHandler class.

@LinZhihao-723 LinZhihao-723 self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants