Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Encoded URI in log viewer. #109

Open
haiqi96 opened this issue Nov 1, 2024 · 2 comments
Open

Support Encoded URI in log viewer. #109

haiqi96 opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@haiqi96
Copy link

haiqi96 commented Nov 1, 2024

Request

I have noticed that the current log viewer doesn't seem to support encoded filepath (it used to be). Opening this issue based on Junhao's request. to keep track of this.

Possible implementation

@haiqi96 haiqi96 added the enhancement New feature or request label Nov 1, 2024
@junhaoliao junhaoliao added bug Something isn't working and removed enhancement New feature or request labels Dec 9, 2024
@junhaoliao
Copy link
Collaborator

Let's mark this as a bug because the log viewer is expected to support URL-encoded filePath parameters.

@junhaoliao
Copy link
Collaborator

Another bug observed:
When loading a log file with a URL that includes query parameters (e.g., ?user=username&password=passwd), the application correctly interprets query parameters such as password as part of the filePath initially. However, when the "Sharing" button is clicked, the password parameter is incorrectly moved to the top-level URL parameters, resulting in a malformed URL where the filePath is no longer valid. This causes improper behavior when generating shareable links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants