Skip to content

Remove empty or falsy parameters from URL hash in handleHashChange() #315

@coderabbitai

Description

@coderabbitai

Summary

There is a TODO comment in src/components/AppController.tsx indicating that we still need to remove empty or falsy parameters from the URL hash after processing it in handleHashChange().

Location

src/components/AppController.tsx around line 127:

// TODO: Remove empty or falsy parameters.

Acceptance Criteria

  • After parsing the URL hash, the application should remove any parameters whose values are empty string, null, undefined, or otherwise falsy.
  • The URL should be updated via updateWindowUrlHashParams without these parameters.
  • Unit tests should be added to cover the new behaviour.

Links

PR: #314
Comment: #314 (comment)
Requested by: @junhaoliao

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions