Skip to content

Remove unintended side effects from updatePageData during loadFile initialization. #339

@Henry8192

Description

@Henry8192

Bug

loadFile uses updatePageData for setting default values during file loading state. However, updatePageData has a few side effects like setting logEventNum and update uiState to ready, which is not expected for this use case.

yscope-log-viewer version

a97a8ed

Environment

N/A

Reproduction steps

  • Try printing uiState inside setUiState, notice that uiState changes from UNOPENED to READY to FILE_LOADING to READY;
  • logEventNum is set to 0 when file is loading.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions