Fix query parameter clearing in updateQueryHashParams

[coderabbitai]

Description

The updateQueryHashParams function in src/components/AppController.tsx currently has an incomplete implementation for clearing query parameters. A line was added to call updateWindowUrlHashParams({queryIsCaseSensitive, queryIsRegex, queryString}) but this doesn't actually clear the parameters because it doesn't set them to their default values.

Context

This issue was discovered during PR #152 where the line was added with the intent to clear query parameters, but the implementation was incomplete.

Tasks

• Fix the updateQueryHashParams function to properly clear query parameters by setting them to default values
• Address the existing TODO comment: TODO: Remove empty or falsy parameters.
• Ensure proper parameter cleanup in URL handling

References

• PR: feat(URL): Support seeking logs by timestamp via URL parameter (resolves #117). #152
• Comment: feat(URL): Support seeking logs by timestamp via URL parameter (resolves #117). #152 (comment)
• Requested by: @hoophalab

[Henry8192]

@hoophalab I remembered that in our offline discussion that this line updateWindowUrlHashParams({queryIsCaseSensitive, queryIsRegex, queryString}) is meant to clear the default value in getWindowUrlHashParams().

If we don't have that line added and we don't input any of the query parameters in the url, getWindowUrlHashParams() would return URL_HASH_PARAMS_DEFAULT, and the url hash parameters will be like `#queryString=&queryIsRegex=false&queryIsCaseSensitive=false".

With that said, I don't think this is an issue, can you confirm?

[hoophalab]

This issue is created based on junhao's comment #152 (comment)

[Henry8192]

@hoophalab I am sure that this is remove empty or falsy parameters is already been resolved in #152.

[hoophalab]

@hoophalab I am sure that this is remove empty or falsy parameters is already been resolved in #152.

Close this issue since @Henry8192 find this is already resolved.