Skip to content

Refactor UI state management in updateViewHashParams. #355

@coderabbitai

Description

@coderabbitai

Problem

After the refactoring in PR #351, the progress bar disappears due to UI state management being scattered across different functions.

Current Hot Fix

A hot fix was implemented by adding setUiState(UI_STATE.FAST_LOADING) directly in the StatusBar component's click handler, but this is not the ideal long-term solution.

Suggested Solutions

Two approaches were discussed for a cleaner implementation:

  1. Set UI_STATE to loading before calling logFileManager inside updateViewHashParams
  2. Use loadPageByAction in updateViewHashParams instead of direct logFileManager calls

Context

This issue arose during the refactoring that extracted individual hash parameter handling functions to centralized updateViewHashParams. The UI state management needs to be cleaned up to ensure consistent loading states across the application.

Backlinks

Requested by: @hoophalab

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions