-
Notifications
You must be signed in to change notification settings - Fork 18
Closed
Description
Problem
After the refactoring in PR #351, the progress bar disappears due to UI state management being scattered across different functions.
Current Hot Fix
A hot fix was implemented by adding setUiState(UI_STATE.FAST_LOADING)
directly in the StatusBar component's click handler, but this is not the ideal long-term solution.
Suggested Solutions
Two approaches were discussed for a cleaner implementation:
- Set
UI_STATE
to loading before callinglogFileManager
insideupdateViewHashParams
- Use
loadPageByAction
inupdateViewHashParams
instead of directlogFileManager
calls
Context
This issue arose during the refactoring that extracted individual hash parameter handling functions to centralized updateViewHashParams
. The UI state management needs to be cleaned up to ensure consistent loading states across the application.
Backlinks
- PR: refactor: Centralize hash parameter handling (fixes #342, #348); Simplify line number updates (fixes #346). #351
- Discussion: refactor: Centralize hash parameter handling (fixes #342, #348); Simplify line number updates (fixes #346). #351 (comment)
Requested by: @hoophalab