-
Notifications
You must be signed in to change notification settings - Fork 18
Closed
Description
Problem Description
The isPrettified
parameter is being discarded when opening URLs, which breaks the ability to share links with prettified state preserved.
Steps to Reproduce
- Open this URL: http://localhost:3010/?filePath=https://yscope.s3.us-east-2.amazonaws.com/sample-logs/yarn-ubuntu-resourcemanager-ip-172-31-17-135.log.1.clp.zst#logEventNum=375558&isPrettified=true
- Notice that the
isPrettified=true
parameter is discarded
Expected Behavior
- The URL should preserve the
isPrettified=true
parameter - Users should be able to share URLs with the prettified state intact
Additional Context
- This issue affects both the main branch and PR refactor: Centralize hash parameter handling (fixes #342, #348); Simplify line number updates (fixes #346). #351
- According to @Henry8192, this functionality used to work in the past but has regressed
- This issue should be addressed together with the "copy link to clipboard" feature