Skip to content

fix: Toggle prettify keyboard shortcut (Alt+Shift+F) doesn't work due to incorrect Monaco key binding #386

@coderabbitai

Description

@coderabbitai

Description

The keyboard shortcut for toggling prettify (Alt+Shift+F) is not working due to incorrect Monaco Editor key binding configuration.

Current Implementation

In src/utils/actions.ts, the key binding is currently defined as:

keybindings: [monaco.KeyMod.Alt | monaco.KeyCode.Shift | monaco.KeyCode.KeyF]

Issue

The problem is using monaco.KeyCode.Shift instead of monaco.KeyMod.Shift. According to Monaco Editor's API, modifier keys should use KeyMod while regular keys should use KeyCode.

Expected Fix

The key binding should be:

keybindings: [monaco.KeyMod.Alt | monaco.KeyMod.Shift | monaco.KeyCode.KeyF]

Context

This issue was discovered during testing of PR #380 which fixes the prettify toggle functionality. The UI toggle and F1 command palette action work correctly, but the direct keyboard shortcut does not.

References

Reported by: @Henry8192
Analysis by: @junhaoliao

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions