Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display real line number in pages #7

Open
haiqi96 opened this issue Mar 2, 2023 · 1 comment
Open

Display real line number in pages #7

haiqi96 opened this issue Mar 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@haiqi96
Copy link

haiqi96 commented Mar 2, 2023

Request

The current design of log viewer display the first line number as 1 on all pages. This is confusing to me at the beginning, because logs in different pages look very similar and I was referring to the line number to see if I have moved to another page.

Possible implementation

Can we let the log viewer display the actual line number in the original file?

@haiqi96 haiqi96 added the enhancement New feature or request label Mar 2, 2023
@vishalpalaniappan
Copy link
Contributor

vishalpalaniappan commented Mar 2, 2023

Hi Haiqi96,

Thanks for the feature request. If we display the real line number, then the space taken up for the line number column will start to increase. In many cases, there are millions of log events, in my opinion this would be worse. Right now, we display the log event that is selected in the status bar, that indicates our progression through the log and line number indicates where we are in the current page.

I might be wrong, I'm going to do some tests (will share the results here) to see how it would look if we kept the original line number across pages. I plan to have infinite scrolling eventually, need to think about how line number would work in this situation.

junhaoliao referenced this issue in junhaoliao/yscope-log-viewer Jan 31, 2024
…z, gzip archives #7

Support downloading decompressed Single-file CLP, zst, zip, tar.gz, gz, gzip archives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants