Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "<=" in verbosity selection is confusing #8

Closed
diy1 opened this issue Mar 2, 2023 · 3 comments
Closed

The "<=" in verbosity selection is confusing #8

diy1 opened this issue Mar 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@diy1
Copy link

diy1 commented Mar 2, 2023

Request

image

The "<=" symbol in front of each verbosity level is confusing. First it took me a while to understand the meaning, and then I thought the opposite symbol, ">=", should be used (where I thought ERROR > INFO for example).

Possible implementation

Why don't we remove this symbol? Users understand the convention that a certain verbosity level is inclusive of all higher priority verbosity levels.

@diy1 diy1 added the enhancement New feature or request label Mar 2, 2023
@vishalpalaniappan
Copy link
Contributor

Hi diy1,

Thanks for the enhancement request. The <= sign was initially added at the request of engineers who found it confusing without it. On further reflection and discussion with the team, a better way to display this would be to have a slider which shows which levels are included in the log. This would remove any ambiguity and likely be the best solution for new and experienced users. I will share a mockup for discussion before implementing the solution.

@diy1
Copy link
Author

diy1 commented Mar 2, 2023

Got it.

@junhaoliao
Copy link
Member

Fixed by #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants