Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rally-domain: Attachments tests and refactor #287

Open
basejump opened this issue Jan 22, 2021 · 1 comment
Open

rally-domain: Attachments tests and refactor #287

basejump opened this issue Jan 22, 2021 · 1 comment
Assignees
@jdabal @snimavat

Comments

@basejump
Copy link
Member

  • move in tests for Attachments
  • need tests for copy.
  • refactor copyAttachments
@basejump
Copy link
Member Author

we do some weird stuff here that we need to get rid of. should be no reason to do it so convoluted. attachment should have everything it needs to find itself.
image

@basejump basejump changed the title rally-domain: tests and refactor rally-domain: Attachments tests and refactor Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdabal jdabal

@snimavat snimavat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@basejump @jdabal @snimavat