From d39e423f8047c6667f4827bb91cd8eef7afecca1 Mon Sep 17 00:00:00 2001 From: srkimir Date: Sat, 14 May 2016 19:59:46 +0200 Subject: [PATCH] - avoid comparing to null with == --- circuit-breaker.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/circuit-breaker.js b/circuit-breaker.js index 9d90e2b..5e74be1 100644 --- a/circuit-breaker.js +++ b/circuit-breaker.js @@ -22,9 +22,9 @@ this._startTicker(); }; - CircuitBreaker.OPEN = 0; - CircuitBreaker.HALF_OPEN = 1; - CircuitBreaker.CLOSED = 2; + CircuitBreaker.OPEN = 'OPEN'; + CircuitBreaker.HALF_OPEN = 'HALF_OPEN'; + CircuitBreaker.CLOSED = 'CLOSED'; // Public API // ---------- @@ -54,7 +54,7 @@ }; CircuitBreaker.prototype.isOpen = function() { - return this._state == CircuitBreaker.OPEN; + return this._state === CircuitBreaker.OPEN; }; // Private API @@ -105,7 +105,7 @@ var bucket = self._lastBucket(); bucket[prop]++; - if (self._forced == null) { + if (!self._forced) { self._updateState(); } @@ -145,7 +145,7 @@ CircuitBreaker.prototype._updateState = function() { var metrics = this._calculateMetrics(); - if (this._state == CircuitBreaker.HALF_OPEN) { + if (this._state === CircuitBreaker.HALF_OPEN) { var lastCommandFailed = !this._lastBucket().successes && metrics.errorCount > 0; if (lastCommandFailed) {