Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtrack errors when trying different scoring matrices #79

Open
glennhickey opened this issue Oct 29, 2024 · 4 comments
Open

Backtrack errors when trying different scoring matrices #79

glennhickey opened this issue Oct 29, 2024 · 4 comments

Comments

@glennhickey
Copy link
Contributor

Hi, I'm experimenting with different scoring matrices. I'm finding that while I often get the desired results on the example I'm looking at, when I try running a non-trivial amount of data I invariably end up with a crash like

[simd_abpoa_align_sequence_to_subgraph] Error in cg_backtrack.

Here's an example to quickly reproduce

https://public.gi.ucsc.edu/~hickey/debug/abpoa_fail_oct29/

(run either of the commmmands in the .cmd files).

Is there something is wrong with my scoring parameters? Are there any constraints on the relative values being used that I should be aware of?

This is in the context of this cactus PR which seeks to automatically learn the parameters from the input data...

thanks!

@yangao07
Copy link
Owner

yangao07 commented Oct 30, 2024

The parameters are fine.
I think this is a bug related to the banding part. I will try to fix it this week.

For your example data, I see this error with ap_in_103573708200432.fa and ap_in_106890945295296.fa, but not with others. Is this the same on your side?

@glennhickey
Copy link
Contributor Author

Thanks so much for looking at this.

You're right, the error only reproduces with those two. The others (with the full paths in the .cmd files) I added after from a failed run on another machine, but they all seem fine. I've removed them from the directory -- sorry about that. Hopefully the two examples are enough for you to resolve the issue.. Thanks again.

yangao07 added a commit that referenced this issue Oct 30, 2024
@yangao07
Copy link
Owner

A quick fix (add820b) was pushed, although I am not sure how this overflow happens yet.
Let me know if this passes the test or not.

@glennhickey
Copy link
Contributor Author

wow, that was fast, thanks!!! I confirm that this patch resolves all crashes on the failing dataset I used to make this issue (yeast chrI as it happens). I will put it into my branch and start a much bigger test on human data, and report any findings back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants