Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize wrapper in _resize() #66

Closed
wants to merge 1 commit into from

Conversation

demonslord
Copy link
Contributor

Resize wrapper in _resize()

Resize wrapper in _resize()
@yanickrochon
Copy link
Owner

Just out of curiosity, no one reported anything broken with the resize function, why the PR?

@demonslord
Copy link
Contributor Author

Hi yanickrochon,
It's not affect anything, is only to complement the _resize() function ;)

PR - just to help you :)

Best Regards.

@yanickrochon
Copy link
Owner

Thank you for your collaboration. By the way, I am not rejecting this PR, however there does not seem to be any reason to add these lines into the codebase. Can you explain how this change affect features and/or any undocumented issue, please?

Thank you.

@demonslord
Copy link
Contributor Author

Hi yanickrochon,
It doesn't affect anything, but in my case i have events in browser resize, which are checking the element size.
And i think it will be more correct and just to avoid problems in the future ;)

Best Regards,
Alexander Bulei

@yanickrochon
Copy link
Owner

I'm sorry, but I will have to close this PR as I am working on other issues that will render this PR obsolete. (See issue #41 and may also affect #86)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants