Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color adjustment #2

Open
kotliary opened this issue Oct 28, 2019 · 7 comments
Open

Color adjustment #2

kotliary opened this issue Oct 28, 2019 · 7 comments

Comments

@kotliary
Copy link

Nice package.
How can I adjust the colors of circles/elipses and borders with either ggvenn or geom_venn?
Also any way to change transparency, border thickness, etc. Thanks.

@yanlinlin82
Copy link
Owner

Thanks for interest and suggestion. So far It does not allow setting the attributes. But I'd like to improve it to support that.

@yanlinlin82
Copy link
Owner

I have added some parameters (such as fill_color and fill_alpha) to both ggvenn() and geom_venn() to support this feature.

@kotliary Could you please try to reinstall the latest version (v0.1.0) package code and try again? Thanks!

@yanlinlin82
Copy link
Owner

Solved in v0.1.0.

@kotliary
Copy link
Author

kotliary commented Nov 7, 2019

Sorry for not responding in time. The new features work great. Love the package.

@yanlinlin82
Copy link
Owner

Thank you for the great encouragement! Suggestions are welcome!

@nh-codem
Copy link

Is there a way to map colors by specifying the names of the sets, like c("Set1" = "black", "Set2" = "green")?

@yanlinlin82
Copy link
Owner

hi, @nh-codem

Thank you for the suggestion.

Here are some examples demonstrating the current behavior:

a = list(`Set 1` = 1:5, `Set 2` = 4:7)

ggvenn(a, fill_color = c(`B` = "green", `A` = "black"))
# ggvenn(a, fill_color = c(`Set 2` = "green", `Set 1` = "black")) # NOTICE: this does not work

Currently, the color names must be hard-coded as 'A', 'B', 'C', and 'D' corresponding to the four sets in sequential order. While this approach is not very intuitive, it serves as a temporary workaround. We recognize this limitation and will consider improving it in future updates to allow for more flexible and user-friendly color mapping.

@yanlinlin82 yanlinlin82 reopened this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants