Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ignore requesting read root when clicking on it #18

Open
mkh-user opened this issue Feb 9, 2025 · 2 comments
Open

[Feature] Ignore requesting read root when clicking on it #18

mkh-user opened this issue Feb 9, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mkh-user
Copy link
Contributor

mkh-user commented Feb 9, 2025

Is your feature request related to a problem? Please describe.
When you click on root in the remote, the plugin requests something that is not possible, in this case the plugin editor will remain on the previous selection because the request made by the plugin is not possible, so it will send a warning to the debugger.
The point is that root is a utility in the remote, so the user is likely to click on it to configure it in the remote, so there must be a way to exclude it from these requests.

Although the plugin checks and manages this so that the user knows it won't work, Signal Lens is a debugging tool, so it's not natural for it to send an alert to the debugger when it doesn't need to.

Describe the solution you'd like
When root is selected, the plugin will ignore it or display a message in the editor panel that provides the necessary explanation.

Additional context
Image

@mkh-user mkh-user added the enhancement New feature or request label Feb 9, 2025
@yannlemos
Copy link
Owner

@mkh-user thanks on the issue and I agree with the approach, I put in the warning as more of a band-aid to avoid the crash, but I don't like polluting users' output and displaying a message inside the debugger panel makes more sense.

Will look into this as soon as possible.

@mkh-user
Copy link
Contributor Author

This warning is a good way, but not for a debug tool.
Perhaps it could be moved to a warning in the editor, like the one displayed in the inactive state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants