Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider deployFiles in sharp and other dictionaries #39

Open
segevfiner opened this issue Feb 28, 2024 · 2 comments
Open

Reconsider deployFiles in sharp and other dictionaries #39

segevfiner opened this issue Feb 28, 2024 · 2 comments

Comments

@segevfiner
Copy link

What version of pkg are you using?

5.11.4

What version of Node.js are you using?

18.9.1

What operating system are you using?

macOS

What CPU architecture are you using?

Apple M1

What Node versions, OSs and CPU architectures are you building for?

default

Describe the Bug

We have deployFiles for some module dictionaries that only really point at *.node files that can safely be bundled if they are included in assets, for example for sharp. Reconsider moving those to assets.

Expected Behavior

Don't tell to copy/deploy directories when not really needed

To Reproduce

Bundle a package that uses sharp or other modules that have deployFiles set.

@robertsLando
Copy link
Member

👍🏼

@Tiarait
Copy link

Tiarait commented Jul 12, 2024

Oh you made my day, thank you! I kept getting error Error: Could not load the "sharp" module using the win32-x64 runtime but turns out I just had to put "node_modules/@img/sharp-win32-x64/**/*" into assets in config pkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants