Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码质量控制建议 #36

Open
orestonce opened this issue Nov 1, 2022 · 5 comments
Open

代码质量控制建议 #36

orestonce opened this issue Nov 1, 2022 · 5 comments

Comments

@orestonce
Copy link
Contributor

  1. 编写测试代码, 提高逻辑代码的测试覆盖率
  2. 使用github action在每次推代码后，自动验证example里面的例子都能编译通过
  3. 建议尽量支持低版本的golang，提高兼容性。我发现go1.12版本无法编译通过，这个也能使用github action自动检查
@yapingcat
Copy link
Owner

感谢，现在我主要还在写rtsp这个模块，写完我抽时间搞一下

@orestonce
Copy link
Contributor Author

好

@pandason125
Copy link

感觉整个项目很全，也很有功底，就是说明性文档，代码注释解释太少了

@yapingcat
Copy link
Owner

感觉整个项目很全，也很有功底，就是说明性文档，代码注释解释太少了

感谢建议。

写文档比较耗精力和时间，自己的时间也比较有限。
在我力能所及的范围内，目前只能通过丰富example来弥补这一块。

@c1ngular
Copy link

benchmark 搞下？想看看性能怎么样

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orestonce @pandason125 @c1ngular @yapingcat