Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] update integration tests once https://github.com/Hamlib/Hamlib/issues/1006 is fixed #3

Open
rubienr opened this issue Apr 9, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rubienr
Copy link
Member

rubienr commented Apr 9, 2022

Description
In rotctl the Easycomm protocol (--model=204) defines a wrong callback easycomm_rot_move_velocity for the \move command.
See Hamlib/Hamlib#1006.

How to reproduce
Run the following integration tests:

def _test_easycomm2_rotctl_v4_move_up():

def _test_easycomm2_rotctl_v4_move_down():

def _test_easycomm2_rotctl_v4_move_left():

def _test_easycomm2_rotctl_v4_move_right():

def _test_easycomm3_rotctl_v4_move_up():

def _test_easycomm3_rotctl_v4_move_down():

def _test_easycomm3_rotctl_v4_move_left():

def _test_easycomm3_rotctl_v4_move_right():

Expected behavior
Once the bug Hamlib/Hamlib#1006 is fixed the listed tests have to be updated accordingly.

@rubienr rubienr added the bug Something isn't working label Apr 9, 2022
@rubienr rubienr self-assigned this Apr 9, 2022
@rubienr rubienr added the good first issue Good for newcomers label Apr 9, 2022
@rubienr rubienr changed the title [BUG] [BUG] update integration tests once https://github.com/Hamlib/Hamlib/issues/1006 is fixed Apr 9, 2022
@rubienr rubienr added enhancement New feature or request and removed bug Something isn't working labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant