[Bug?]: unexpected to evaluate the devDependencies of a dependence package from git source even when there is no build script in it.

[AmyFoxFN]

Self-service

• I'd be willing to implement a fix

Describe the bug

When:

• use yarn command to install a dependence package from Git Source;
• there are no build scripts in the git package;
• there is a dev dependence package whose descriptor is "workspace:*", and it's not hosted in the repository of the git package.

what happens:

• yarn failed with YN0058.

 YN0058: │ git-source-package@git+ssh://git@github.com:AmyFoxFN/yarn-demo-git-source-package.git#commit=b367f12603cbc45eb3db49d44d6363e928f6b6d5: Packing the package failed (exit code 1, logs can be found here: /private/var/folders/vk/jl551z8j4157nvxvv9wj1sqr0000gn/T/xfs-a1cb5754/pack.log)

• errors in pack.log.

ct [Error]: local-workspace@workspace:*: No local workspace found for this range
    at xVe (/Users/didi/.node/corepack/yarn/3.2.0/yarn.js:712:37482)
    at Xa.triggerHook (/Users/didi/.node/corepack/yarn/3.2.0/yarn.js:396:3373)
    at Yue (/Users/didi/.node/corepack/yarn/3.2.0/yarn.js:712:30939)
    at /Users/didi/.node/corepack/yarn/3.2.0/yarn.js:712:30487 {
  reportExtra: undefined,
  reportCode: 21
}

To reproduce

await expect(packageJsonAndInstall({
  dependencies: {
    [`git-source-package`]: `git+ssh://git@github.com:AmyFoxFN/yarn-demo-git-source-package.git#b367f12603cbc45eb3db49d44d6363e928f6b6d5`,
  }
})).resolves.toBeTruthy()

It seems the default sherlock reproduction env could not install packages by git+ssh. You may need to use my own demo to reproduce:

• the git source package
• the demo of installing the git package

Environment

System:
    OS: macOS 12.6
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 16.17.0 - /private/var/folders/vk/jl551z8j4157nvxvv9wj1sqr0000gn/T/xfs-75b5a995/node
    Yarn: 3.3.0 - /private/var/folders/vk/jl551z8j4157nvxvv9wj1sqr0000gn/T/xfs-75b5a995/yarn
    npm: 8.15.0 - /usr/local/bin/npm

Additional context

Related issue #1915

[yarnbot]

The reproduction case in your issue seems broken (ie it neither pass nor fail due to throwing an unmanaged exception):

Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js install

➤ YN0000: ┌ Resolution step
::group::Resolution step
➤ YN0001: │ Error: git-source-package@[^2.0.0-rc.3](git+ssh://git@github.com:AmyFoxFN/yarn-demo-git-source-package.git#b367f12603cbc45eb3db49d44d6363e928f6b6d5) isn't supported by any available resolver
    at MultiResolver.getResolverByDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:73:13)
    at MultiResolver.bindDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:31:27)
    at Project.preparePackage (/github/workspace/packages/yarnpkg-core/sources/Project.ts:668:30)
    at startPackageResolution (/github/workspace/packages/yarnpkg-core/sources/Project.ts:754:21)
::endgroup::
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 28ms

    at ChildProcess.exithandler (node:child_process:400:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1093:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

Remember: any non-Jest exceptions will cause the test to be reported as broken. If you expect something to pass without throwing, you must wrap it into something like await expect(...).resolves.toBeTruthy(). If you instead expect something to throw, you need to wrap it into await expect(...).rejects.toThrow().

[yarnbot]

The reproduction case in your issue seems broken (ie it neither pass nor fail due to throwing an unmanaged exception):

Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js install

➤ YN0000: ┌ Resolution step
::group::Resolution step
➤ YN0001: │ Error: git-source-package@[^2.0.0-rc.3](git+ssh://git@github.com:AmyFoxFN/yarn-demo-git-source-package.git#b367f12603cbc45eb3db49d44d6363e928f6b6d5) isn't supported by any available resolver
    at MultiResolver.getResolverByDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:73:13)
    at MultiResolver.bindDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:31:27)
    at Project.preparePackage (/github/workspace/packages/yarnpkg-core/sources/Project.ts:668:30)
    at startPackageResolution (/github/workspace/packages/yarnpkg-core/sources/Project.ts:754:21)
::endgroup::
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 28ms

    at ChildProcess.exithandler (node:child_process:400:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1093:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

Remember: any non-Jest exceptions will cause the test to be reported as broken. If you expect something to pass without throwing, you must wrap it into something like await expect(...).resolves.toBeTruthy(). If you instead expect something to throw, you need to wrap it into await expect(...).rejects.toThrow().

[yarnbot]

We couldn't reproduce your issue (all the assertions passed on master).

[yarnbot]

We couldn't reproduce your issue (all the assertions passed on master).

[yarnbot]

This issue reproduces on master:

Error: expect(received).resolves.toBeTruthy()

Received promise rejected instead of resolved
Rejected to value: [Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js install

➤ YN0000: ┌ Resolution step
::group::Resolution step
➤ YN0001: │ git-source-package@git+ssh://git@github.com:AmyFoxFN/yarn-demo-git-source-package.git#b367f12603cbc45eb3db49d44d6363e928f6b6d5: Failed listing refs
➤ YN0001: │   Repository URL: git@github.com:AmyFoxFN/yarn-demo-git-source-package.git
➤ YN0001: │   Ssh -o batchmode=yes Error: line 1: ssh: not found
➤ YN0001: │   Fatal Error: Could not read from remote repository.
➤ YN0001: │   �[38;5;111mExit Code�[39m: �[38;5;220m128�[39m
::endgroup::
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 63ms
]
    at expect (/github/workspace/.yarn/cache/expect-npm-24.8.0-8c7640c562-44ff9ab1e7.zip/node_modules/expect/build/index.js:138:15)
    at module.exports (evalmachine.<anonymous>:2:7)
    at /github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.3-558f52b79f-286d94b96d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:57:19
    at executeInTempDirectory (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.3-558f52b79f-286d94b96d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:18:22)
    at executeRepro (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.3-558f52b79f-286d94b96d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:25:18)
    at ExecCommand.execute (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.3-558f52b79f-286d94b96d.zip/node_modules/@arcanis/sherlock/lib/commands/exec.js:26:76)
    at async ExecCommand.validateAndExecute (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-4061026d74.zip/node_modules/clipanion/lib/advanced/Command.js:161:26)
    at async Cli.run (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-4061026d74.zip/node_modules/clipanion/lib/advanced/Cli.js:74:24)
    at async Cli.runExit (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-4061026d74.zip/node_modules/clipanion/lib/advanced/Cli.js:83:28)

[yarnbot]

The reproduction case in your issue seems broken (ie it neither pass nor fail due to throwing an unmanaged exception):

Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js install

➤ YN0000: ┌ Resolution step
::group::Resolution step
➤ YN0001: │ git-source-package@git+ssh://git@github.com:AmyFoxFN/yarn-demo-git-source-package.git#b367f12603cbc45eb3db49d44d6363e928f6b6d5: Failed listing refs
➤ YN0001: │   Repository URL: git@github.com:AmyFoxFN/yarn-demo-git-source-package.git
➤ YN0001: │   Ssh -o batchmode=yes Error: line 1: ssh: not found
➤ YN0001: │   Fatal Error: Could not read from remote repository.
➤ YN0001: │   �[38;5;111mExit Code�[39m: �[38;5;220m128�[39m
::endgroup::
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 83ms

    at ChildProcess.exithandler (node:child_process:400:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1093:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

Remember: any non-Jest exceptions will cause the test to be reported as broken. If you expect something to pass without throwing, you must wrap it into something like await expect(...).resolves.toBeTruthy(). If you instead expect something to throw, you need to wrap it into await expect(...).rejects.toThrow().