Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: use terminal colors #6440

Open
1 of 2 tasks
litoj opened this issue Aug 6, 2024 · 4 comments
Open
1 of 2 tasks

[Feature]: use terminal colors #6440

litoj opened this issue Aug 6, 2024 · 4 comments
Labels
enhancement New feature or request external bug This issue highlights a bug in another project

Comments

@litoj
Copy link

litoj commented Aug 6, 2024

  • I'd be willing to implement this feature (contributing guide)
  • This feature is important to have in this repository; a contrib plugin wouldn't do

Describe the user story

This is basically unreadable:
obrazek

Describe the solution you'd like

Ideally, use the terminal colours by default. Or at least there should be an option for it.

Describe the drawbacks of your solution

Theoretically, the TTY would offer only 8 different colours. But who uses yarn in a TTY?

Describe alternatives you've considered

I couldn't find any workarounds - the colours seem to be hardcoded.

@litoj litoj added the enhancement New feature or request label Aug 6, 2024
@arcanis
Copy link
Member

arcanis commented Aug 6, 2024

I don't feel like there's enough value in making those configurable that it's worth the maintenance/complexity cost.

@arcanis arcanis added the waiting for feedback Will autoclose in a while unless more data are provided label Aug 6, 2024
@litoj
Copy link
Author

litoj commented Aug 6, 2024

Making it configurable would be a burden indeed. But would it be an issue if just the terminal colors were used?

@yarnbot
Copy link
Collaborator

yarnbot commented Sep 5, 2024

Hi! 👋

It seems like this issue as been marked as probably resolved, or missing important information blocking its progression. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it.

@yarnbot yarnbot added the stale Issues that didn't get attention label Sep 5, 2024
@clemyan
Copy link
Member

clemyan commented Sep 5, 2024

Making it configurable would be a burden indeed. But would it be an issue if just the terminal colors were used?

We use chalk to color our output, so in theory setting FORCE_COLOR=1 should do exactly that. But sounds like that is bugged right now

@clemyan clemyan added external bug This issue highlights a bug in another project and removed waiting for feedback Will autoclose in a while unless more data are provided stale Issues that didn't get attention labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external bug This issue highlights a bug in another project
Projects
None yet
Development

No branches or pull requests

4 participants