-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couldn't find documentation about single-file build or what "legacy" means #311
Comments
From @glasser on December 14, 2016 2:10 Also perhaps worth documenting that if you use this version, you won't have |
@bestander Do we need to keep building the "legacy" build? I agree that it's confusing, and it would be better if we could just omit it and only have the "modern" version. |
We still have a major client using node4 version in fbsource afaik. |
@bestander - Does the "legacy" build work on newer Node.js versions? If so, perhaps we should just have the legacy one, to simplify things a bit? |
Yeah, of course "legacy" works for with Node 4+. So yeah, I would say, let's build only "legacy" JS for releases. |
From @glasser on December 14, 2016 1:36
Do you want to request a feature or report a bug?
Documentation issue
What is the current behavior?
Yarn publishes (in GitHub releases) a "modern" and "legacy" single-file JavaScript build.
This build doesn't seem to be documented anywhere other than in a random section in a blog post.
It also takes a fair amount of poking around (not inside the files themselves!) to learn that "legacy" means Node 4 and "non-legacy" means Node 5.
These builds (which are useful!) should be documented, maybe in https://yarnpkg.com/en/docs/install#alternatives-tab , maybe in the release notes themselves.
Perhaps one could even change the build process to add a simple explanatory output (including required Node versions) to the top of the files.
Please mention your node.js, yarn and operating system version.
Just looking at https://github.com/yarnpkg/yarn/releases as of 0.18.0
Copied from original issue: yarnpkg/yarn#2248
The text was updated successfully, but these errors were encountered: