Skip to content

Commit 0dc672a

Browse files
committed
fix: design-review
1 parent ec1436e commit 0dc672a

File tree

10 files changed

+18
-7
lines changed

10 files changed

+18
-7
lines changed

src/components/JsonViewer/JsonViewer.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@
7272
}
7373

7474
&__filter {
75+
--g-button-height: 24px;
76+
--g-button-border-radius: 4px;
7577
width: 300px;
7678
}
7779

src/components/SyntaxHighlighter/YDBSyntaxHighlighter.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ export function YDBSyntaxHighlighter({
6868
className={b('copy', {
6969
visible: alwaysVisible,
7070
})}
71+
view="flat-secondary"
7172
/>
7273
</div>
7374
);

src/containers/Configs/Configs.scss

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
--data-table-start: calc(
1818
var(--sticky-tabs-height, 0px) + var(--ydb-configs-controls-height)
1919
);
20-
--ydb-table-with-controls-layout-controls-height: 46px;
20+
--ydb-table-with-controls-layout-controls-height: 44px;
21+
}
22+
&__startup {
23+
pre {
24+
border-radius: 4px;
25+
}
2126
}
2227
}

src/containers/Configs/Configs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export function Configs({database, className, scrollContainerRef}: ConfigsProps)
2626
case ConfigTypes.current:
2727
return <Config database={database} />;
2828
case ConfigTypes.startup:
29-
return <Startup database={database} />;
29+
return <Startup database={database} className={b('startup')} />;
3030
case ConfigTypes.features:
3131
return <FeatureFlags database={database} className={b('feature-flags')} />;
3232
}

src/containers/Configs/components/FeatureFlags/FeatureFlags.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ export const FeatureFlags = ({database, className}: FeatureFlagsProps) => {
107107
value={featureFlagsFilter}
108108
onChange={handleSearchChange}
109109
placeholder={i18n('search-placeholder')}
110+
width={300}
110111
/>
111112
</TableWithControlsLayout.Controls>
112113
<TableWithControlsLayout.Table loading={isLoading}>

src/containers/Configs/components/Startup/Startup.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ import {useAutoRefreshInterval} from '../../../../utils/hooks/useAutoRefreshInte
66

77
interface StartupProps {
88
database?: string;
9+
className?: string;
910
}
10-
export function Startup({database}: StartupProps) {
11+
export function Startup({database, className}: StartupProps) {
1112
const [autoRefreshInterval] = useAutoRefreshInterval();
1213
const {currentData, isLoading, error} = configsApi.useGetConfigQuery(
1314
{database},
@@ -21,6 +22,7 @@ export function Startup({database}: StartupProps) {
2122
{error ? <ResponseError error={error} /> : null}
2223
{startup ? (
2324
<YDBSyntaxHighlighterLazy
25+
className={className}
2426
language="yaml"
2527
text={startup}
2628
transparentBackground={false}

src/containers/Configs/i18n/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"disabled": "Disabled",
88
"flag-touched": "Flag is changed",
99

10-
"search-placeholder": "Search by feature flag",
10+
"search-placeholder": "Search...",
1111
"search-empty": "Empty search result",
1212
"no-data": "No data",
1313

src/containers/Tenant/Diagnostics/Diagnostics.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
&__page-wrapper {
2929
--ydb-configs-controls-height: 46px;
3030
--ydb-configs-container-height: 100cqh;
31-
--ydb-table-with-controls-layout-controls-height: 46px;
31+
--ydb-table-with-controls-layout-controls-height: 44px;
3232
--ydb-table-with-controls-layout-controls-padding-top: 0px;
3333
overflow: auto;
3434
flex-grow: 1;

src/containers/Tenant/Query/QueriesHistory/QueriesHistory.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
@use '../../../../styles/mixins.scss';
22

33
.ydb-queries-history {
4-
--ydb-table-with-controls-layout-controls-height: 46px;
4+
--ydb-table-with-controls-layout-controls-height: 44px;
55
overflow: auto;
66

77
height: 100%;

src/containers/Tenant/Query/SavedQueries/SavedQueries.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
.ydb-saved-queries {
44
$block: &;
55

6-
--ydb-table-with-controls-layout-controls-height: 46px;
6+
--ydb-table-with-controls-layout-controls-height: 44px;
77

88
overflow: auto;
99

0 commit comments

Comments
 (0)