Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for using keyword #397

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add support for using keyword #397

wants to merge 2 commits into from

Conversation

polRk
Copy link
Member

@polRk polRk commented Aug 14, 2024 •
edited
Loading

Pull request type

Please check one the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What does it do?

Adds disposable support

Why is it needed?

Closes #353

How to test it?

{
   await using driver = new Driver()
}
// driver destroyed

Related issue(s)/PR(s)

#353

@polRk polRk force-pushed the feat/add-support-using branch from 99d6809 to 5d3ecb0 Compare August 14, 2024 07:52
@polRk polRk changed the title [WIP]: feat: add support for using keyword feat: add support for using keyword Aug 14, 2024
@Zork33
Copy link
Collaborator

Zork33 commented Aug 21, 2024

Hi! I have attempted to do some basic test - https://github.com/ydb-platform/ydb-nodejs-sdk/blob/feat/add-support-using/src/__tests__/e2e/using-keyword.test.ts and received the following error:

TypeError: Symbol.asyncDispose is not defined.|

Seems that something is still missing to start using 'using'

@polRk
Copy link
Member Author

polRk commented Sep 10, 2024

TypeError: Symbol.asyncDispose is not defined.

Hi! Please, provide information about your runtime.

@polRk
Copy link
Member Author

polRk commented Oct 8, 2024

@Zork33 I think, the problem is about your runtime (maybe needs extra compile step)

❯ bun test src/__tests__/e2e/using-keyword.test.ts
bun test v1.1.21 (70ca2b76)

src/__tests__/e2e/using-keyword.test.ts:
Works

@polRk polRk force-pushed the main branch 8 times, most recently from 9ca020e to b5d1115 Compare December 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add support of using keyword for driver and session management
2 participants
@polRk @Zork33