fix: after comments

Author: fatalem0

.github/workflows/slo.yml

@@ -38,15 +38,12 @@ jobs:
 
     strategy:
       matrix:
-        sdk:
-          - name: native
-            label: native
         rust_version:
           - "RUST_VERSION_OLD"
           - "RUST_VERSION_NEW"
 
     concurrency:
-      group: slo-${{ github.ref }}-${{ matrix.sdk.name }}-${{ matrix.rust_version }}
+      group: slo-${{ github.ref }}-native-${{ matrix.rust_version }}
       cancel-in-progress: true
 
     steps:
@@ -75,31 +72,30 @@ jobs:
           REF=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}
           REF_SAFE=${REF//\//__}
           echo "METRICS_REF=$REF_SAFE" >> $GITHUB_ENV
-          echo "METRICS_LABEL=${{ matrix.sdk.label }}" >> $GITHUB_ENV
-          echo "METRICS_JOB_NAME=${{ matrix.sdk.name }}" >> $GITHUB_ENV
+          echo "METRICS_LABEL=native" >> $GITHUB_ENV
+          echo "METRICS_JOB_NAME=native" >> $GITHUB_ENV
 
       - name: Initialize YDB SLO
         uses: ydb-platform/ydb-slo-action/init@main
         with:
           github_pull_request_number: ${{ github.event.inputs.github_pull_request_number }}
           github_token: ${{ secrets.GITHUB_TOKEN }}
-          workload_name: ${{ matrix.sdk.name }}-${{ matrix.rust_version }}
+          workload_name: native-${{ matrix.rust_version }}
           ydb_database_node_count: 5
 
       - name: Prepare SLO Database
         run: |
-          cargo run --example ${{ matrix.sdk.name }} grpc://localhost:2135 /Root/testdb tableName create
+          cargo run -- -t tableName grpc://localhost:2135 /Root/testdb create
 
       - name: Run SLO Tests
         run: |
-          cargo run --example ${{ matrix.sdk.name }} grpc://localhost:2135 /Root/testdb tableName run \
+          cargo run -- -t tableName --write-timeout 1 grpc://localhost:2135 /Root/testdb run \
             --prom-pgw localhost:9091 \
-            --report-period 250 \
+            --report-period 1 \
             --time ${{ inputs.slo_workload_duration_seconds || 600}} \
             --read-rps ${{ inputs.slo_workload_read_max_rps || 1000}} \
             --write-rps ${{ inputs.slo_workload_write_max_rps || 100}} \
-            --read-timeout 1000 \
-            --write-timeout 1000 || true
+            --read-timeout 1 || true
 
       - if: always()
         name: Store ydb chaos testing logs
@@ -109,14 +105,14 @@ jobs:
       - if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ matrix.sdk.name}}-${{ matrix.rust_version }}-chaos-ydb.log
+          name: native-${{ matrix.rust_version }}-chaos-ydb.log
           path: ./chaos-ydb.log
           retention-days: 1
 
       - if: always()
         name: Cleanup SLO Database
         run: |
-          cargo run --example ${{ matrix.sdk.name }} grpc://localhost:2135 /Root/testdb tableName cleanup || true
+          cargo run -- -t tableName grpc://localhost:2135 /Root/testdb cleanup || true
   validate-slo-metrics:
     name: Validate SLO metrics
     needs: ydb-slo-action-init
@@ -148,7 +144,7 @@ jobs:
       - name: Download metrics artifact
         uses: actions/download-artifact@v4
         with:
-          name: ${{ matrix.sdk.name }}-${{ matrix.rust_version }}-metrics.json
+          name: native-${{ matrix.rust_version }}-metrics.json
           path: ./artifacts
 
       - name: Make script executable
@@ -157,4 +153,4 @@ jobs:
       - name: Validate SLO thresholds
         run: |
           .github/scripts/check-metrics.sh \
-            ./artifacts/${{ matrix.sdk.name }}-${{ matrix.rust_version }}-metrics.json
+            ./artifacts/native-${{ matrix.rust_version }}-metrics.json

Cargo.lock

@@ -5,5 +5,6 @@ members = [
     "ydb-grpc",
     #    "ydb-grpc-helpers",
     "ydb-example-urlshortener",
-    "ydb-slo-tests",
+    "ydb-slo-tests/lib",
+    "ydb-slo-tests/native",
 ]

Cargo.toml

@@ -15,72 +15,82 @@ It has 3 commands:
 
 create:
 
-`cargo run --example native grpc://localhost:2136 /local tableName create --min-partitions-count 6 --max-partitions-count 1000 --partition-size 1 -c 1000 --write-timeout 10000`
+`cargo run -- -t testingTable --write-timeout 10 --db-init-timeout 3 grpc://localhost:2136 /local create --min-partitions-count 6 --max-partitions-count 1000 --partition-size 1 -c 1000`
 
 cleanup:
 
-`cargo run --example native grpc://localhost:2136 /local tableName cleanup`
+`cargo run -- -t testingTable --write-timeout 10 --db-init-timeout 3 grpc://localhost:2136 /local cleanup`
 
 run:
 
-`cargo run --example native grpc://localhost:2136 /local tableName run -c 1000 --read-rps 1000 --read-timeout 10000 --write-rps 100 --write-timeout 10000 --time 600 --prom-pgw localhost:9091 --report-period 250`
+`cargo run -- -t testingTable --write-timeout 10 --db-init-timeout 3 grpc://localhost:2136 /local run -c 1000 --read-rps 1000 --read-timeout 10 --write-rps 100 --prom-pgw localhost:9091 --time 600 --report-period 1 --shutdown-time 30`
 
-## Arguments for commands:
+## Arguments and options for commands:
 
 ### create
 
-`cargo run --example <example_name> <ENDPOINT> <DB> <TABLE_NAME> create [OPTIONS]`
+`cargo run [COMMON_OPTIONS] <ENDPOINT> <DB> create [OPTIONS]`
 
 ```
 Arguments:
   ENDPOINT                            YDB endpoint to connect to
   DB                                  YDB database to connect to
-  TABLE_NAME                          table name to create
+  
+Common options:
+  -t --table-name            <string> table name to create [default: testingTable]
+  --write-timeout            <u64>    write timeout in seconds [default: 10]
+  --db-init-timeout          <u64>    YDB database initialization timeout in seconds [default: 3]
 
 Options:
-  --min-partitions-count     <u64>    minimum amount of partitions in table
-  --max-partitions-count     <u64>    maximum amount of partitions in table
-  --partition-size           <u64>    partition size in mb
+  -c --initial-data-count    <u64>    amount of initially created rows [default: 1000]
   
-  -c --initial-data-count    <u64>    amount of initially created rows
+  --min-partitions-count     <u64>    minimum amount of partitions in table [default: 6]
   
-  --write-timeout            <u64>    write timeout milliseconds
+  --max-partitions-count     <u64>    maximum amount of partitions in table [default: 1000]
+  --partition-size           <u64>    partition size in mb [default: 1]
 ```
 
 ### cleanup
 
-`cargo run --example <example_name> <ENDPOINT> <DB> <TABLE_NAME> cleanup`
+`cargo run [COMMON_OPTIONS] <ENDPOINT> <DB> cleanup`
 
 ```
 Arguments:
   ENDPOINT    YDB endpoint to connect to
   DB          YDB database to connect to
-  TABLE_NAME  table name to cleanup
+  
+Common options:
+  -t --table-name            <string> table name to create [default: testingTable]
+  --write-timeout            <u64>    write timeout in seconds [default: 10]
+  --db-init-timeout          <u64>    YDB database initialization timeout in seconds [default: 3]
 ```
 
 ### run
 
-`cargo run --example <example_name> <ENDPOINT> <DB> <TABLE_NAME> run`
+`cargo run [COMMON_OPTIONS] <ENDPOINT> <DB> run [OPTIONS]`
 
 ```
 Arguments:
   ENDPOINT                            YDB endpoint to connect to
   DB                                  YDB database to connect to
-  TABLE_NAME                          table name to use
+  
+Common options:
+  -t --table-name            <string> table name to create [default: testingTable]
+  --write-timeout            <u64>    write timeout in seconds [default: 10]
+  --db-init-timeout          <u64>    YDB database initialization timeout in seconds [default: 3]
 
-Options:
-  -c --initial-data-count    <u64>    amount of initially created rows
+Options:  
+  -c --initial-data-count    <u64>    amount of initially created rows [default: 1000]
                          
-  --read-rps                 <u32>    read RPS
-  --read-timeout             <u64>    read timeout milliseconds
-                         
-  --write-rps                <u32>    write RPS
-  --write-timeout            <u64>    write timeout milliseconds
-                         
-  --time                     <u64>    run time in seconds
+  --read-rps                 <u32>    read RPS [default: 1000]
+  --write-rps                <u32>    write RPS [default: 100]
+  
+  --prom-pgw                 <string> prometheus push gateway [default: ]
   
-  --prom-pgw                 <string> prometheus push gateway
-  --report-period            <u64>    prometheus push period in milliseconds
+  --read-timeout             <u64>    read timeout in seconds [default: 10]
+  --time                     <u64>    write timeout in seconds [default: 600]
+  --report-period            <u64>    prometheus push period in seconds [default: 1]
+  --shutdown-time            <u64>    time to wait before force kill workers in seconds [default: 30]
 ```
 
 ## What's inside