From 00b3434fdaebc950635377ec45d70e4ab72ce502 Mon Sep 17 00:00:00 2001 From: Github Security Lab Date: Sun, 8 Mar 2020 03:16:21 +0100 Subject: [PATCH] `vallen` is verified to be less than `len`, therefore, it can never be the case that `vallen >= len + sizeof(rhostname)`. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR fixes the check so the `rhostname` array does not overflow. Reported-by: Github Security Lab Signed-off-by: Alvaro Muñoz --- config/Kconfig | 15 --------------- user/pppd/pppd/eap.c | 4 ++-- 2 files changed, 2 insertions(+), 17 deletions(-) delete mode 100644 config/Kconfig diff --git a/config/Kconfig b/config/Kconfig deleted file mode 100644 index b7a19fe74..000000000 --- a/config/Kconfig +++ /dev/null @@ -1,15 +0,0 @@ -############################################################################# - -# -# Kconfig - user space configuration -# - -############################################################################# - -mainmenu "Linux Application Configuration" - -source ../lib/Kconfig - -source ../user/Kconfig - -############################################################################# diff --git a/user/pppd/pppd/eap.c b/user/pppd/pppd/eap.c index 6203f94d0..48547e6be 100644 --- a/user/pppd/pppd/eap.c +++ b/user/pppd/pppd/eap.c @@ -1421,7 +1421,7 @@ int len; } /* Not so likely to happen. */ - if (vallen >= len + sizeof (rhostname)) { + if (len - vallen >= sizeof (rhostname)) { dbglog("EAP: trimming really long peer name down"); BCOPY(inp + vallen, rhostname, sizeof (rhostname) - 1); rhostname[sizeof (rhostname) - 1] = '\0'; @@ -1847,7 +1847,7 @@ int len; } /* Not so likely to happen. */ - if (vallen >= len + sizeof (rhostname)) { + if (len - vallen >= sizeof (rhostname)) { dbglog("EAP: trimming really long peer name down"); BCOPY(inp + vallen, rhostname, sizeof (rhostname) - 1); rhostname[sizeof (rhostname) - 1] = '\0';