Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task [fonts] will not work with last bootstrap-sass 3.3.5 #338

Closed
viniciusdacal opened this issue Jun 17, 2015 · 5 comments
Closed

Task [fonts] will not work with last bootstrap-sass 3.3.5 #338

viniciusdacal opened this issue Jun 17, 2015 · 5 comments

Comments

@viniciusdacal
Copy link

they remove fonts from bower.main
twbs/bootstrap-sass@e62a79b#diff-0a08a7565aba4405282251491979bb6b

@silvenon
Copy link
Member

Thanks for reporting 👍 I will see what's the best way to deal with this…

silvenon added a commit that referenced this issue Jun 17, 2015
v3.3.5 removed fonts from their bower.json, so our fonts task won't work. We are temporarily locking to v3.3.4 until #338 is resolved.
@jaromero
Copy link
Contributor

A (temporary) workaround is now provided by Bootstrap, using overrides in bower.json:

http://blog.getbootstrap.com/2015/06/15/bootstrap-3-3-5-released/#wiredep-and-bower

From my tests, it works fine with the current wiredep. EDIT: or with main-bower-files anyway, which is what takes care of font files in this case.

Whenever bower decides to provide a files field as well and bootstrap makes use of it, these overrides can be removed.

jaromero added a commit to jaromero/generator-gulp-webapp that referenced this issue Jun 22, 2015
jaromero added a commit to jaromero/generator-gulp-webapp that referenced this issue Jun 22, 2015
Revert commit ecf4928 (Lock Bootstrap to v3.3.4)

Add bower.json overrides for bootstrap (yeoman#338)

Add test for bootstrap's bower.json overrides
@jaromero
Copy link
Contributor

(Apologies for the multiple notifications)

I've updated the _bower.json template here. I'm not convinced by the tests I added though, since I couldn't find a way to actually test for the result of the fonts task, only whether the bower.json file had the proper overrides (and even then, maybe I should've just checked for "overrides" instead of every single added line).

If the overrides workaround is acceptable though, and if this looks good, I'll just go ahead and submit the PR.

@silvenon
Copy link
Member

Hey, that's a great fix, a PR would be awesome 👍

What do you think about using assets/fonts/bootstrap/* instead of naming each font individually?

@jaromero
Copy link
Contributor

Sure, I can do that. It also works from what I saw. I had just done each font individually because that's what bootstrap's bower.json had before but it should not matter either way.

jaromero added a commit to jaromero/generator-gulp-webapp that referenced this issue Jun 23, 2015
Revert commit ecf4928 (Lock Bootstrap to v3.3.4)

Add bower.json overrides for bootstrap (yeoman#338)

Add test for bootstrap's bower.json overrides
jaromero added a commit to jaromero/generator-gulp-webapp that referenced this issue Jun 23, 2015
Revert commit ecf4928 (Lock Bootstrap to v3.3.4)

Add bower.json overrides for bootstrap (yeoman#338)

Add test for bootstrap's bower.json overrides

Update bootstrap to v3.3.5
silvenon added a commit that referenced this issue Jun 23, 2015
Add bower.json overrides for bootstrap (#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants