-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task [fonts] will not work with last bootstrap-sass 3.3.5 #338
Comments
Thanks for reporting 👍 I will see what's the best way to deal with this… |
v3.3.5 removed fonts from their bower.json, so our fonts task won't work. We are temporarily locking to v3.3.4 until #338 is resolved.
A (temporary) workaround is now provided by Bootstrap, using http://blog.getbootstrap.com/2015/06/15/bootstrap-3-3-5-released/#wiredep-and-bower From my tests, it works fine with the current wiredep. EDIT: or with main-bower-files anyway, which is what takes care of font files in this case. Whenever bower decides to provide a |
Revert commit ecf4928 (Lock Bootstrap to v3.3.4) Add bower.json overrides for bootstrap (yeoman#338) Add test for bootstrap's bower.json overrides
(Apologies for the multiple notifications) I've updated the _bower.json template here. I'm not convinced by the tests I added though, since I couldn't find a way to actually test for the result of the If the overrides workaround is acceptable though, and if this looks good, I'll just go ahead and submit the PR. |
Hey, that's a great fix, a PR would be awesome 👍 What do you think about using |
Sure, I can do that. It also works from what I saw. I had just done each font individually because that's what bootstrap's bower.json had before but it should not matter either way. |
Revert commit ecf4928 (Lock Bootstrap to v3.3.4) Add bower.json overrides for bootstrap (yeoman#338) Add test for bootstrap's bower.json overrides
Revert commit ecf4928 (Lock Bootstrap to v3.3.4) Add bower.json overrides for bootstrap (yeoman#338) Add test for bootstrap's bower.json overrides Update bootstrap to v3.3.5
Add bower.json overrides for bootstrap (#338)
they remove fonts from bower.main
twbs/bootstrap-sass@e62a79b#diff-0a08a7565aba4405282251491979bb6b
The text was updated successfully, but these errors were encountered: