Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile time benchmarks in CI? #432

Open
Kmeakin opened this issue Dec 21, 2022 · 1 comment
Open

Compile time benchmarks in CI? #432

Kmeakin opened this issue Dec 21, 2022 · 1 comment

Comments

@Kmeakin
Copy link
Contributor

Kmeakin commented Dec 21, 2022

I've submitted some PRs in the past that remove some inefficiencies in the compiler (#427, #426). In those cases, they were obvious performance wins, but in the future we might want to include compile time benchmarks in CI, so we can measure performance changes and catch regressions.

Information on benchmarking rust code in CI is scarce. Criterion recommends iai. We should also investigate what other compilers (eg rustc, cranelift) use.

@brendanzab
Copy link
Member

Yeah, this would be nice! I need to be better at profiling as well to be honest. Stuff like memory usage and performance of binary parsing would be nice as well perhaps?

I think I’ve also seen some places that it’s worth taking CI-based profiling with a grain of salt due to it being run on shared infrastructure. Curious to know about best practices but it still might be a useful thing to do at any rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants