Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add curl comment and printing #939

Closed
wants to merge 4 commits into from
Closed

Add curl comment and printing #939

wants to merge 4 commits into from

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Sep 9, 2023

Trying to have some sort of way to eleviate #910

Don't see any way of adding a curl dependency to the .cabal file, so this comment and dummy test should help anyone trying to run the tests in case they don't have curl installed. 🤷

WithApplication
  "curl" dependency
    All "WithApplication" tests assume the "curl" process can be called directly.
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Vlix added 3 commits September 9, 2023 18:30
@Vlix
Added dummy test to 'WithApplicationSpec' to notify very obviously th…
91b61d3 
…at the tests need the curl to function. Also removed the commented out test, since MkSocket isn't exported anymore since network-3.0.0.0
@Vlix
added extra-deps to the stack.yaml since you can't build warp without…
a75c678 
… them (they are not on stackage)
@Vlix
Merge branch 'master' into add-curl-comment-and-printing
13f13e0
@kazu-yamamoto kazu-yamamoto self-requested a review September 12, 2023 00:10
kazu-yamamoto
kazu-yamamoto approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Sep 12, 2023
@kazu-yamamoto
Merge PR yesodweb#939
e9024f0
@kazu-yamamoto
Copy link
Contributor

Rebased and merged.
Thanks.

@Vlix Vlix mentioned this pull request Sep 14, 2023
Closed
@Vlix Vlix closed this Sep 14, 2023
@Vlix Vlix deleted the add-curl-comment-and-printing branch September 14, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @kazu-yamamoto