Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warp: changed check in 'waitForZero' to never loop indefinitely and arguably be more readable. #940

Merged
merged 1 commit into from
Sep 10, 2023
Merged

warp: changed check in 'waitForZero' to never loop indefinitely and arguably be more readable. #940

merged 1 commit into from
Sep 10, 2023

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Sep 9, 2023

Doesn't need a version bump or anything.

Based on #893

@kazu-yamamoto kazu-yamamoto self-requested a review September 10, 2023 07:29
kazu-yamamoto
kazu-yamamoto approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 5bffe8c into yesodweb:master Sep 10, 2023
3 of 15 checks passed
@kazu-yamamoto
Copy link
Contributor

Merged.
Thanks!

@Vlix Vlix mentioned this pull request Sep 10, 2023
Closed
@kazu-yamamoto kazu-yamamoto mentioned this pull request Oct 3, 2023
Merged
@Vlix Vlix deleted the waitforzero-tweak branch October 13, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @kazu-yamamoto