Fix checking match and modified headers #945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' headers have one value, but there can be more
… to pass it to lots more functions, and immediately also moved the checking of 'isHead' to where it was actually needed
… 9110 prescribes it.
…' and 'If-(Un)Modified-Since' headers interact as expected.
kazu-yamamoto
added a commit
to kazu-yamamoto/wai
that referenced
this pull request
Oct 13, 2023
|
Rebased and merged. Thanks! |
|
Shall I add this change to the Changelog as well? Or is it fine as is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
After submitting your PR:
Not completely sure this needs a version bump?
Can be added to the next version when it comes around. (tagging along with #943 ?)
This addresses #842 and implements the condition checking in the way the RFC 9110 prescribes.
Also noticed a few other spots that were "lacking", so also added some FIXME and TODOs.