Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp: if we're building the outgoing buffer, why not count the bytes? #946

Closed

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Oct 12, 2023

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Would this justify a version bump? 🤔

... come to think of it, should the bytesSent type be in Integer, to be able to count more than 2GB on a 32 bit machine?

@kazu-yamamoto kazu-yamamoto self-requested a review October 13, 2023 03:45
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Oct 13, 2023
@kazu-yamamoto
Copy link
Contributor

Rebased and merged. Thanks!

@kazu-yamamoto
Copy link
Contributor

Should we release a new version of warp?

@Vlix
Copy link
Contributor Author

Vlix commented Oct 13, 2023

I'll make a PR with the last two changes added to the Changelog, and I think I'm going to change the counting type to Integer, just so there's no chance of hitting the 2,1GB limit on 32-bit machines.
Then we can release warp-3.3.30 (but I can do that too, if necessary 😄 )

Vlix added a commit to Vlix/wai that referenced this pull request Oct 13, 2023
@Vlix Vlix closed this Oct 13, 2023
@Vlix Vlix deleted the calculate-length-of-ResponseBuilders branch October 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants