delete unnecessary isHead plumbing through RspFile #960
+8
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a CI fluke? It passed on everything except stack nightly Windows. |
|
I restarted CI. |
kazu-yamamoto
added a commit
to kazu-yamamoto/wai
that referenced
this pull request
Dec 22, 2023
|
Rebased and merged. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes what appears to be some unnecessary
isHead :: Boolplumbing via theRspFileconstructor.Where the
isHeadfield was referenced, we also havemethodin scope, from whichisHeadwas originally derived. We can just use that.