Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent thunks from building when calculating size in 'toBufWith' #967

Closed
wants to merge 1 commit into from
Closed

prevent thunks from building when calculating size in 'toBufWith' #967

wants to merge 1 commit into from

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Jan 4, 2024

Small correction that I missed when making #946

@kazu-yamamoto
Copy link
Contributor

This PR has no effect since Strict is specified in the cabal file.
Rather, we should delete all !.

@Vlix
Copy link
Contributor Author

Vlix commented Jan 9, 2024

Might be a good idea to double check there aren't any sections that are assuming laziness then. 🤔
How long has the Strict pragma been enabled by default?

@kazu-yamamoto
Copy link
Contributor

This one:

commit ce607dd19dcd7ed42c28c173667a8d6abfb8d46c
Author: Kazu Yamamoto <[email protected]>
Date:   Mon Jun 17 10:41:50 2019 +0900

    using strict language extensions.

@Vlix Vlix closed this Jan 10, 2024
@Vlix Vlix deleted the forgotten-strictness-annotation branch January 10, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @kazu-yamamoto