-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
When a binding contains parenthesis then the Path= syntax must be used. This prevents a TypeNameParserException being thrown on initialization.
Sorry for the delay, it got too far down in my inbox somehow. Can you explain why that Path= is required here? Do you have a reference for that? Because it was always the default parameter and worked fine for me. |
Hey, no problem. Are you not seeing the issue (#17) I reported? If not, I need to work out what the difference is between yours and my setups and come up with a repo. |
I still don't get it. Can you explain me how I can view your commit without blindly accepting it? Github is getting so confusing. :-( I have never observed this exception so I don't know where it should come from. |
I've created a project to demonstrate the problem - you can find it here: https://github.com/grokys/MultiSelectTreeViewProblem. Make sure VS is set to break on CLR exceptions and then run that project and you should see the exception. Let me know if you don't! As for handling pull requests, have you read the GitHub docs? https://help.github.com/categories/63/articles |
I cannot open your project. Can you save it for VS2010? |
Alright. As far as I know, and as far as it has always worked for me, the Path= syntax is entirely optional and equivalent to leaving it away if the path is the first argument. So I consider your change equivalent to the current version. But I'd still like to reproduce your bug with your project. I just tried with mine, with exceptions being enabled, and nothing happened. |
The project should be compatible with VS2010 - as far as I know VS2013 is backwards compatible. But this may be the reason we're seeing different results... |
Additionally, I originally found the solution to the problem (adding the parenthesis) somewhere on the internet. I can't find it now, however :( |
Hm. I still cannot open your project. I tried with deleting some lines and updating some numbers in the sln and csproj file, and I saw the ungrade wizard, but the result was still unusable. It's for later versions, it says. So much about compatibility at Microsoft... |
When a binding contains parenthesis then the Path= syntax must be used.
Fixes #17