Skip to content
This repository has been archived by the owner on May 7, 2022. It is now read-only.

Add Path= qualifier to bindings. #18

Closed
wants to merge 1 commit into from
Closed

Conversation

grokys
Copy link

@grokys grokys commented Jul 24, 2013

When a binding contains parenthesis then the Path= syntax must be used.
Fixes #17

When a binding contains parenthesis then the Path= syntax must be used.
This prevents a TypeNameParserException being thrown on initialization.
@ygoe
Copy link
Owner

ygoe commented Oct 17, 2013

Sorry for the delay, it got too far down in my inbox somehow.

Can you explain why that Path= is required here? Do you have a reference for that? Because it was always the default parameter and worked fine for me.

@grokys
Copy link
Author

grokys commented Oct 17, 2013

Hey, no problem. Are you not seeing the issue (#17) I reported?

If not, I need to work out what the difference is between yours and my setups and come up with a repo.

@ygoe
Copy link
Owner

ygoe commented Mar 24, 2014

I still don't get it. Can you explain me how I can view your commit without blindly accepting it? Github is getting so confusing. :-( I have never observed this exception so I don't know where it should come from.

@grokys
Copy link
Author

grokys commented Mar 24, 2014

I've created a project to demonstrate the problem - you can find it here: https://github.com/grokys/MultiSelectTreeViewProblem. Make sure VS is set to break on CLR exceptions and then run that project and you should see the exception. Let me know if you don't!

As for handling pull requests, have you read the GitHub docs? https://help.github.com/categories/63/articles

@ygoe
Copy link
Owner

ygoe commented Mar 24, 2014

I cannot open your project. Can you save it for VS2010?

@ygoe
Copy link
Owner

ygoe commented Mar 24, 2014

Alright. As far as I know, and as far as it has always worked for me, the Path= syntax is entirely optional and equivalent to leaving it away if the path is the first argument. So I consider your change equivalent to the current version. But I'd still like to reproduce your bug with your project. I just tried with mine, with exceptions being enabled, and nothing happened.

@grokys
Copy link
Author

grokys commented Mar 24, 2014

The project should be compatible with VS2010 - as far as I know VS2013 is backwards compatible. But this may be the reason we're seeing different results...

@grokys
Copy link
Author

grokys commented Mar 24, 2014

Additionally, I originally found the solution to the problem (adding the parenthesis) somewhere on the internet. I can't find it now, however :(

@ygoe
Copy link
Owner

ygoe commented Mar 24, 2014

Hm. I still cannot open your project. I tried with deleting some lines and updating some numbers in the sln and csproj file, and I saw the ungrade wizard, but the result was still unusable. It's for later versions, it says. So much about compatibility at Microsoft...

@grokys
Copy link
Author

grokys commented Mar 24, 2014

Sorry, I've not got VS2010 installed. I guess the best I can do it to paste a screenshot to prove it's happening ;)

image

@grokys grokys closed this Jan 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeNameParserException is thrown on initialization
2 participants