Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX #116

Open
Larzans opened this issue Sep 21, 2024 · 9 comments
Open

OSX #116

Larzans opened this issue Sep 21, 2024 · 9 comments

Comments

@Larzans
Copy link

Larzans commented Sep 21, 2024

Is there any prebuild package for osx or does that not exist anymore?
It says everywhere win, linux, osx, but i can't see the binaries.

Is there a doc on how to compile on osx, if possible?
I know the old site and forum has been deleted, i downloaded the backup, but i can't seem to find my way around it.

So it would be appreciated if anyone could give me a tip on how to proceed on osx :)

@ygrek
Copy link
Owner

ygrek commented Sep 21, 2024

documentation needs updating / transfer from old site yes.
Meanwhile can see the MacOS build in CI, e.g. the last one as of now https://github.com/ygrek/mldonkey/actions/runs/10589860995/job/29344666172 and see the commands it runs. Or see the github actions file at https://github.com/ygrek/mldonkey/blob/master/.github/workflows/workflow.yml
The binaries built by CI are available at the bottom of the page https://github.com/ygrek/mldonkey/actions/runs/10589860995 , i have no idea if they are usable :) but you are welcome to try

@Larzans
Copy link
Author

Larzans commented Sep 22, 2024

Thx @ygrek ,
that got me an executable, but it was compiled for osx 14, which i don't have.
Could you also compile for OSX 13, then i could test if it works and show you the possible error messages.

@ygrek
Copy link
Owner

ygrek commented Sep 25, 2024

i have no idea how to do that, but you can follow what ci is doing and build yourself
and please lmk what works and what doesn't

@barracuda156
Copy link
Contributor

Thx @ygrek , that got me an executable, but it was compiled for osx 14, which i don't have. Could you also compile for OSX 13, then i could test if it works and show you the possible error messages.

@Larzans I am planning to update it in MacPorts now.

@Larzans
Copy link
Author

Larzans commented Sep 30, 2024

@barracuda156 Interesting, with which target? Currently it is OSX 14 minimum, but i have 13.

@HinTak
Copy link
Contributor

HinTak commented Sep 30, 2024

CI is run on pulls as far as I see, so you can just replace all the "macos-latest" with "macos-13": (I counted 3, but there might be more I missed)

os: macos-latest

if: matrix.os == 'macos-latest'

if: matrix.os == 'macos-latest'

Do a pull, and collect the artefact yourself from the action tab (then close the pull afterwards, whether it works or not).

@ygrek
Copy link
Owner

ygrek commented Sep 30, 2024

or better submit a PR to do macos-13 builds

@HinTak
Copy link
Contributor

HinTak commented Sep 30, 2024

Oh yes, replace the first with [macos-latest, macos-13], and the other with some ... or .... In that case you need to make a 4th change to distinguish the two output artefact names, perhaps too?

@barracuda156
Copy link
Contributor

@barracuda156 Interesting, with which target? Currently it is OSX 14 minimum, but i have 13.

@Larzans As long as it is feasible, MacPorts will support 10.5+ on all 7 archs.

Normally I build everything on 10.6 PowerPC and then CI must pass on 12–14 x86_64 and arm64. Everything in between is not guaranteed, but we may fix it if something fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants