Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] fix broken tests #17

Open
6 tasks
thep2p opened this issue May 30, 2021 · 0 comments
Open
6 tasks

[Testing] fix broken tests #17

thep2p opened this issue May 30, 2021 · 0 comments

Comments

@thep2p
Copy link
Owner

thep2p commented May 30, 2021

Context:

  • Running mvn test as part of our CI was supposed to run all tests and fail CI if any test would fail. However, we noticed that it is currently not configured properly, and hence there are a handful of broken tests sitting on master branch.

  • The purpose of this issue is to configure the maven plugins in the project properly so that any broken test would fail the CI. As the candidate, we suggest Surefire plugin of maven be adopted to our project.

  • Once the plugging is set properly, the broken tests should be identified, their root cause investigated, and fixed one by one.

How to proceed?

  • Create a branch <yourname>/<issue-number>-<issue-name>
  • Make sure that you setup the Surefire plugin has setup correctly so that mvn test will _run all tests in src/test/java/** packages. Even develop a simple test and intentionally let it fail to verify whether Surefire can catch it properly.
  • Identify all broken tests, start by the easiest one to fix, and fix it, and repeat this process iteratively till all tests are passed.

Definition of Done:

  • Surefire plugin has been configured properly.
  • mvn test will run all tests in specified package and will detect and catch any broken test.
  • All broken tests have been identified and fixed one by one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants