Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Params for Put and Delete? #1551

Open
mrexodia opened this issue Apr 7, 2023 · 2 comments
Open

Missing Params for Put and Delete? #1551

mrexodia opened this issue Apr 7, 2023 · 2 comments

Comments

@mrexodia
Copy link
Contributor

mrexodia commented Apr 7, 2023

Today I was trying to use the client library (usually I use the server) and noticed that the Delete function doesn't have an overload with Params. Is this intentional or will you accept a PR with this change?

I extracted this table of general REST guidelines from ChatGPT:

HTTP Method Usage Request Body? Query Parameters?
GET/HEAD Retrieve data No Yes
POST Create resource Yes No
PUT Update resource Yes No
DELETE Delete resource No Yes
PATCH Partial update Yes No
@mrexodia mrexodia changed the title Missing Params for Put, Delete and Options? Missing Params for Put and Delete? Apr 7, 2023
@yhirose
Copy link
Owner

yhirose commented Apr 7, 2023

@mrexodia thanks for the feedback. It's not intentional, but just left out since my use cases so far don't require it. A pull request with a unit test case is always welcome!

@thedayofcondor
Copy link

Client::Post has a Parameters overload, but that overload does not seem to allow you to set the body.

@yhirose yhirose mentioned this issue Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants