diff --git a/src/craftground/environment/socket_ipc.py b/src/craftground/environment/socket_ipc.py index e91cd2fd..c316a709 100644 --- a/src/craftground/environment/socket_ipc.py +++ b/src/craftground/environment/socket_ipc.py @@ -214,3 +214,4 @@ def _connect_server(self, server_event: threading.Event): raise Exception("Server not started within 1024 seconds") wait_time += 1 time.sleep(1) + raise RuntimeError("Minecraft process failed to start") diff --git a/tests/python/unit/test_environment.py b/tests/python/unit/test_environment.py index 95d1ecf7..081d06f3 100644 --- a/tests/python/unit/test_environment.py +++ b/tests/python/unit/test_environment.py @@ -60,16 +60,18 @@ def test_initialize_boost_environment(mock_ipc_class, mock_initial_env): @patch("socket.socket") @patch("subprocess.Popen") -def test_start_server(mock_popen, mock_socket, environment): +def test_reset(mock_popen, mock_socket, environment): mock_process = MagicMock() mock_popen.return_value = mock_process mock_sock_instance = MagicMock() mock_socket.return_value = mock_sock_instance - environment.start_server(seed=1234) + with pytest.raises(RuntimeError): + environment.reset(seed=1234) assert mock_popen.called - assert environment.process is not None + # assert mock_socket.called + # assert environment.process is not None @patch("builtins.open", new_callable=MagicMock)