switch statements with strings cannot be tidied

[bioinformatist]

Hi Yihui,

To reproduce this matter, you can use code snippets below:

matrix.please <- function(x) {
  m<-as.matrix(x[,-1])
  rownames(m)<-x[,1]
  m
}

merge.duplicates <- function(x, method = "median") {
  switch(method,
         "median" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = median)),
         "mean" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = mean)),
         "max" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = max)),
         "min" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = min)),
         "var" = get.max.var.rows(x))
}

I got error as:

Error in base::parse(text = code, keep.source = FALSE) : 
  <text>:44:1: unexpected string constant
43: 
44: "median"
    ^

[yihui]

I cannot reproduce it. It works well for me:

formatR::tidy_source(text = 'matrix.please <- function(x) {
  m<-as.matrix(x[,-1])
  rownames(m)<-x[,1]
  m
}

merge.duplicates <- function(x, method = "median") {
  switch(method,
         "median" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = median)),
         "mean" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = mean)),
         "max" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = max)),
         "min" = matrix.please(aggregate(x, by=list(row.names(x)), FUN = min)),
         "var" = get.max.var.rows(x))
}
')

Output:

matrix.please <- function(x) {
    m <- as.matrix(x[, -1])
    rownames(m) <- x[, 1]
    m
}

merge.duplicates <- function(x, method = "median") {
    switch(method, median = matrix.please(aggregate(x, by = list(row.names(x)), FUN = median)), mean = matrix.please(aggregate(x, 
        by = list(row.names(x)), FUN = mean)), max = matrix.please(aggregate(x, by = list(row.names(x)), 
        FUN = max)), min = matrix.please(aggregate(x, by = list(row.names(x)), FUN = min)), var = get.max.var.rows(x))
}

[bioinformatist]

I'm so sorry that it is caused by same situation as this matter.

Sorry for wasting your time! Closed.