Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception on pass empty string to Tag::id() #221

Open
vjik opened this issue Oct 18, 2024 · 1 comment
Open

Add exception on pass empty string to Tag::id() #221

vjik opened this issue Oct 18, 2024 · 1 comment
Labels
severity:BC breaking Breaks backwards compatibility status:ready for adoption Feel free to implement this issue.

Comments

@vjik
Copy link
Member

vjik commented Oct 18, 2024

ID can't be empty string. Suggest to check it and throw LogicException if value is empty string.
@vjik vjik added status:under discussion severity:BC breaking Breaks backwards compatibility labels Oct 18, 2024
@samdark
Copy link
Member

samdark commented Oct 18, 2024

Makes sense.

@samdark samdark added status:ready for adoption Feel free to implement this issue. and removed status:under discussion labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:BC breaking Breaks backwards compatibility status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @vjik