Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the methods getAllAssignments(), getAllRoles, getAllRules() in Manager::class #73

Open
terabytesoftw opened this issue Nov 24, 2021 · 2 comments
Assignees
Labels
status:ready for adoption Feel free to implement this issue.
Milestone

Comments

@terabytesoftw
Copy link
Member

terabytesoftw commented Nov 24, 2021

I think it would be a good thing to return these methods in manager since they are resolved within the class, which is ideal for creating an rbac service.

@terabytesoftw terabytesoftw changed the title Implement the methods getAllAssignments(), getAllRoles, ge in Manager::class Implement the methods getAllAssignments(), getAllRoles, getRules() in Manager::class Nov 24, 2021
@terabytesoftw terabytesoftw changed the title Implement the methods getAllAssignments(), getAllRoles, getRules() in Manager::class Implement the methods getAllAssignments(), getAllRoles, getAllRules() in Manager::class Nov 24, 2021
@samdark
Copy link
Member

samdark commented Jan 10, 2022

It's good to have these but it won't work for real-world cases:

  1. If there are too many assignments (and that is very likely) pagination is needed.
  2. For a good UI, more it needed: you'll likely need an ability to search and auto-complete items etc.

@samdark
Copy link
Member

samdark commented Jan 11, 2022

I think it's a good idea to release without these and then add it in a subsequent major release.

@arogachev arogachev self-assigned this Sep 12, 2023
@arogachev arogachev added status:ready for adoption Feel free to implement this issue. and removed status:under discussion labels Sep 12, 2023
@arogachev arogachev modified the milestones: 2.0, 3.0 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

No branches or pull requests

3 participants