Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right-branching result do not match with that presented in the paper #3

Open
SyahX opened this issue Jan 26, 2019 · 3 comments
Open

Comments

@SyahX
Copy link

SyahX commented Jan 26, 2019

Hi,
I am trying to compute right-branching and upper bound baselines on the WSJ10 dataset. When I use the code in prpn to evaluation, I get 56.68 (right-branching) and 84.06 (upper bound), different from 61.7(RBranch) 88.1(upper bound) in the paper. But when I use EvalB to do the evaluation, I get 61.7(RBranch) 88.1(upper bound).
So is that mean the way to evaluate the right-branching structure is different from prpn model? Could you please show the right way to compute right-branching and upper bound baselines on the WSJ10 dataset?

Thanks,
Yunfan

@yoonkim
Copy link

yoonkim commented Feb 8, 2019

I think the discrepancy is due to sentence-level F1 (adopted by PRPN) vs corpus-level F1 (adopted by EVALB and previous works). Thus the numbers are not exactly comparable, though they are in the general ballpark. There does seem to be a lack of consistency across grammar induction papers (preprocessing, evaluation metric, including sentence-level span vs not, etc.) to make inter-paper comparison difficult to say the least.

Quick question, what did you get for the right branching baselines on the entire dataset?

@SyahX
Copy link
Author

SyahX commented Feb 16, 2019

40.348, right branching baseline for WSJ40

@yikangshen
Copy link
Owner

Thanks for pointing this out. I am using the baseline results from previous papers. Could you push the code for evaluation with EvalB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants