Skip to content

Commit

Permalink
Revert back to hard-coded proxy #242
Browse files Browse the repository at this point in the history
  • Loading branch information
jissereitsma committed Aug 22, 2024
1 parent b4ed9ab commit 0ef22c6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 18 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [3.9.5] - 22 August 2024
### Fixed
- Revert back to hard-coded proxy #242

## [3.9.4] - 14 August 2024
### Fixed
- Guarantee `subtotal` is always float
Expand Down
2 changes: 1 addition & 1 deletion Util/SecureHtmlRendererStub.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace Yireo\GoogleTagManager2\Util;

if (class_exists('\Magento\Framework\View\Helper\SecureHtmlRenderer')) {
class SecureHtmlRendererStub extends \Magento\Framework\View\Helper\SecureHtmlRenderer {}
class SecureHtmlRendererStub extends \Magento\Framework\View\Helper\SecureHtmlRenderer\Proxy {}
} else {
class SecureHtmlRendererStub
{
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "yireo/magento2-googletagmanager2",
"version": "3.9.4",
"version": "3.9.5",
"license": "OSL-3.0",
"type": "magento2-module",
"homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",
Expand Down
16 changes: 0 additions & 16 deletions etc/frontend/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,4 @@
</argument>
</arguments>
</type>

<type name="Yireo\GoogleTagManager2\Observer\FixNonExistingSecureRenderer">
<arguments>
<argument name="secureHtmlRendererStub" xsi:type="object">
Yireo\GoogleTagManager2\Util\SecureHtmlRendererStub\Proxy
</argument>
</arguments>
</type>

<type name="Yireo\GoogleTagManager2\Plugin\AddCspInlineScripts">
<arguments>
<argument name="secureHtmlRendererStub" xsi:type="object">
Yireo\GoogleTagManager2\Util\SecureHtmlRendererStub\Proxy
</argument>
</arguments>
</type>
</config>

0 comments on commit 0ef22c6

Please sign in to comment.