Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce index-type-size limits at AOT generation (i.e. "compile") time. #1100

Open
ltratt opened this issue Apr 17, 2024 · 0 comments
Open
Assignees

Comments

@ltratt
Copy link
Contributor

ltratt commented Apr 17, 2024

In the JIT IR we have various type size limits (e.g. 24 bit indexes) that we have to check dynamically, even though most of them can easily be enforced at AOT generation (i.e. "compile") time. For example, 9c91e81 shows that we can check that the type indexes we generate at AOT always fit within 24 bits: that would make the code in "main" yk clearer, because we'd know that any unwraps were guaranteed not to fail (unless we've done something stupid; i.e. the unwrap would become equivalent to an assert rather than the current "we've not worked out how to handle this case yet").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants