From 959f214cfebc5101a947ab70e93041cfaf2f55f0 Mon Sep 17 00:00:00 2001
From: yan ma <yan.ma@intel.com>
Date: Thu, 8 Aug 2024 17:56:38 +0800
Subject: [PATCH] fix internal tests

---
 velox/dwio/parquet/reader/RepeatedColumnReader.cpp | 14 ++++++++++++++
 velox/dwio/parquet/reader/RepeatedColumnReader.h   | 10 ++++++++++
 2 files changed, 24 insertions(+)

diff --git a/velox/dwio/parquet/reader/RepeatedColumnReader.cpp b/velox/dwio/parquet/reader/RepeatedColumnReader.cpp
index c86af99eb908..f7a5f0fa832b 100644
--- a/velox/dwio/parquet/reader/RepeatedColumnReader.cpp
+++ b/velox/dwio/parquet/reader/RepeatedColumnReader.cpp
@@ -211,6 +211,13 @@ void MapColumnReader::read(
   elementReader_->seekTo(childTargetReadOffset_, false);
 }
 
+void MapColumnReader::filterRowGroups(
+    uint64_t rowGroupSize,
+    const dwio::common::StatsContext& context,
+    dwio::common::FormatData::FilterRowGroupsResult& result) const {
+  // empty placeholder to avoid incorrect calling on parent's impl
+}
+
 ListColumnReader::ListColumnReader(
     const TypePtr& requestedType,
     const std::shared_ptr<const dwio::common::TypeWithId>& fileType,
@@ -306,4 +313,11 @@ void ListColumnReader::read(
   child_->seekTo(childTargetReadOffset_, false);
 }
 
+void ListColumnReader::filterRowGroups(
+    uint64_t rowGroupSize,
+    const dwio::common::StatsContext& context,
+    dwio::common::FormatData::FilterRowGroupsResult& result) const {
+  // empty placeholder to avoid incorrect calling on parent's impl
+}
+
 } // namespace facebook::velox::parquet
diff --git a/velox/dwio/parquet/reader/RepeatedColumnReader.h b/velox/dwio/parquet/reader/RepeatedColumnReader.h
index eaa4baa7d865..317b374b79ee 100644
--- a/velox/dwio/parquet/reader/RepeatedColumnReader.h
+++ b/velox/dwio/parquet/reader/RepeatedColumnReader.h
@@ -97,6 +97,11 @@ class MapColumnReader : public dwio::common::SelectiveMapColumnReader {
   /// supplied before receiving new lengths.
   void skipUnreadLengths();
 
+  void filterRowGroups(
+      uint64_t rowGroupSize,
+      const dwio::common::StatsContext&,
+      dwio::common::FormatData::FilterRowGroupsResult&) const override;
+
  private:
   RepeatedLengths lengths_;
   RepeatedLengths keyLengths_;
@@ -148,6 +153,11 @@ class ListColumnReader : public dwio::common::SelectiveListColumnReader {
   /// supplied before receiving new lengths.
   void skipUnreadLengths();
 
+  void filterRowGroups(
+      uint64_t rowGroupSize,
+      const dwio::common::StatsContext&,
+      dwio::common::FormatData::FilterRowGroupsResult&) const override;
+
  private:
   RepeatedLengths lengths_;
   arrow::LevelInfo levelInfo_;