-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max: Create/Set Project Folder when starting Max or task changed #2
Max: Create/Set Project Folder when starting Max or task changed #2
Conversation
… into the prelaunch hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small notes (see comments) but other than that code looks good.
I do think, if one were to "save" into another task that has no workfiles yet from the workfiles tool in Max itself it will not create and hence not set the project for that context. Not sure if critical, but that may be an issue one may face with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside of a logging level note - code looks good to me. Ready for test run.
This note I think may also still be relevant for a future issue:
I do think, if one were to "save" into another task that has no workfiles yet from the workfiles tool in Max itself it will not create and hence not set the project for that context. Not sure if critical, but that may be an issue one may face with this.
0b371e7
to
6fc1f24
Compare
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Changelog Description
Ported from ynput/ayon-core#475